-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add PS256, PS384 and PS512 support #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add support for PS512
too, so that we support all of the algorithms listed on jwt.io
And if you think it's appropriate, add a doc comment regarding the minimum key size.
Also your tests are failing on MacOS with Swift 4.0.3: This may be because the xcode image is too old (xcode9.2 seems to give you MacOS 10.12.6) |
I have updated our RSA key to be 2048 bit so that it can be used for ps512. I have also added if available calls to our tests since RSA-PSS requires MacOS 10.13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This pull request adds two now signers and verifiers for the PS256 and PS384 JWT algorithms.
These use the new RSA-PSS support introduced in BlueRSA 1.0.31.
Tests have been added for sign -> verify cycle and against the JWT.io implementation by using a JWT they generated and generating a JWT that is then verfied on JWT.io.
This adds the functionality requested by issue #55.